Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

8321409: Console read line with zero out should zero out underlying buffer in JLine (redux) #3

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Dec 8, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321409: Console read line with zero out should zero out underlying buffer in JLine (redux) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/jdk22.git pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/3.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4ed38f5ad5f822ab948257ed39717ea919fd32ed 8321409: Console read line with zero out should zero out underlying buffer in JLine (redux) Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@naotoj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Dec 8, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2023
@naotoj
Copy link
Member Author

naotoj commented Dec 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2023

Going to push as commit e5684da.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2023
@openjdk openjdk bot closed this Dec 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@naotoj Pushed as commit e5684da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants