Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds #32

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Jan 4, 2024

backport of PR: openjdk/jdk#17252


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.org/jdk22.git pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/32.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

@JoeWang-Java JoeWang-Java changed the title 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds Backport 755722ced60a686799c7f419feae61c04ce41f09 Jan 4, 2024
@openjdk openjdk bot changed the title Backport 755722ced60a686799c7f419feae61c04ce41f09 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a6e3565: 8321515: ARM32: Move method resolution information out of the cpCache properly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2024
@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

Going to push as commit b121931.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a6e3565: 8321515: ARM32: Move method resolution information out of the cpCache properly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2024
@openjdk openjdk bot closed this Jan 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@JoeWang-Java Pushed as commit b121931.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants