Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322725: (tz) Update Timezone Data to 2023d#35

Closed
lutkerd wants to merge 1 commit intoopenjdk:masterfrom
lutkerd:8322725
Closed

8322725: (tz) Update Timezone Data to 2023d#35
lutkerd wants to merge 1 commit intoopenjdk:masterfrom
lutkerd:8322725

Conversation

@lutkerd
Copy link

@lutkerd lutkerd commented Jan 5, 2024

Clean backport tzdata 2023d.
make test TEST="test/jdk/java/util/TimeZone test/jdk/java/time/test test/jdk/sun/util/resources test/jdk/sun/text/resources test/jdk/sun/util/calendar" is all passing


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322725: (tz) Update Timezone Data to 2023d (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.org/jdk22.git pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/35.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2024

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc 8322725: (tz) Update Timezone Data to 2023d Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@lutkerd The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 5, 2024
@lutkerd lutkerd marked this pull request as ready for review January 5, 2024 17:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2024

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the backport.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322725: (tz) Update Timezone Data to 2023d

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 6aace18: 8319948: jcmd man page needs to be updated
  • 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2024
@lutkerd
Copy link
Author

lutkerd commented Jan 9, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@lutkerd
Your change (at version 6a9e74e) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Jan 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit acc4829.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 6aace18: 8319948: jcmd man page needs to be updated
  • 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@naotoj @lutkerd Pushed as commit acc4829.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants