8322532: JShell : Unnamed variable issue

[lahodaj]

Hi all,

This pull request contains a backport of commit f0cfd361 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 5 Jan 2024 and was reviewed by Adam Sotona.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322532: JShell : Unnamed variable issue (Bug - P3)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/jdk22.git pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/36.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1d8b8def)

[kevinrushforth]

If the bug priority is correct, it doesn't seem to meet the criteria for JDK 22 backports during RDP1.

[lahodaj]

If the bug priority is correct, it doesn't seem to meet the criteria for JDK 22 backports during RDP1.

Oops, sorry, I thought I've update the priority, but apparently I didn't. Fixed now, including ILW. Thanks!

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322532: JShell : Unnamed variable issue

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
• f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
• 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
• 6aace18: 8319948: jcmd man page needs to be updated
• 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
• 01cb043: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
• bb0e203: 8321582: yield .class not parsed correctly.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 29ed387.
Since your change was applied there have been 7 commits pushed to the master branch:

• 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
• f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
• 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
• 6aace18: 8319948: jcmd man page needs to be updated
• 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
• 01cb043: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
• bb0e203: 8321582: yield .class not parsed correctly.

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 29ed387.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.