-
Notifications
You must be signed in to change notification settings - Fork 30
8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 #43
8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 #43
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
|
Add a comment to update this pr and make skara bot evaluate this pr again. |
This backport pull request has now been updated with issue from the original commit. |
@RealCLanger The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
d2a6dec
to
3c67a25
Compare
@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 28db238.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 28db238. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8322163, commit 12308533 from the openjdk/jdk repository.
The commit being backported was authored by Matthias Baesken on 22 Dec 2023 and was reviewed by Martin Doerr and Christoph Langer.
The bug is P3 and hence appropriate for RDP1. It quieces a test error that we see regularly on Alpine.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/43/head:pull/43
$ git checkout pull/43
Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.org/jdk22.git pull/43/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 43
View PR using the GUI difftool:
$ git pr show -t 43
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/43.diff
Webrev
Link to Webrev Comment