Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 #43

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jan 9, 2024

Hi all,

This pull request contains a backport of JDK-8322163, commit 12308533 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 22 Dec 2023 and was reviewed by Martin Doerr and Christoph Langer.

The bug is P3 and hence appropriate for RDP1. It quieces a test error that we see regularly on Alpine.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/43/head:pull/43
$ git checkout pull/43

Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.org/jdk22.git pull/43/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 43

View PR using the GUI difftool:
$ git pr show -t 43

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/43.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @RealCLanger could not find any commit with hash 1230853343c38787c90820d19d0626f0c37540dc. Please update the title with the hash for an existing commit.

@RealCLanger RealCLanger changed the title Backport 1230853343c38787c90820d19d0626f0c37540dc Backport JDK-8322163 Jan 9, 2024
@RealCLanger RealCLanger changed the title Backport JDK-8322163 Backport 1230853343c38787c90820d19d0626f0c37540dc Jan 9, 2024
@zhaosongzs
Copy link
Member

Add a comment to update this pr and make skara bot evaluate this pr again.

@openjdk openjdk bot changed the title Backport 1230853343c38787c90820d19d0626f0c37540dc 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886 Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@RealCLanger The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 6b79e79: 8323241: jcmd manpage should use lists for argument lists
  • a8df559: 8321480: ISO 4217 Amendment 176 Update
  • acc4829: 8322725: (tz) Update Timezone Data to 2023d
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

Going to push as commit 28db238.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 6b79e79: 8323241: jcmd manpage should use lists for argument lists
  • a8df559: 8321480: ISO 4217 Amendment 176 Update
  • acc4829: 8322725: (tz) Update Timezone Data to 2023d
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2024
@openjdk openjdk bot closed this Jan 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@RealCLanger Pushed as commit 28db238.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-RealCLanger-12308533 branch January 10, 2024 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants