Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process #52

Closed

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Jan 10, 2024

Hi all,

This pull request contains a backport of commit d2d58dd6 from the openjdk/jdk repository.

The commit being backported was authored by Jorn Vernee on 10 Jan 2024 and was reviewed by Maurizio Cimadamore.

This is a P2 test only change, and we are currently in Ramp Down Phase 1. The release process allows P1-P5 test-only changes during RDP1: https://openjdk.org/jeps/3#Quick-reference

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process (Bug - P2)
  • JDK-8322637: java/foreign/critical/TestCriticalUpcall.java timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.org/jdk22.git pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/52.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2024

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d2d58dd6a8ec366a4bc3eb12a253b252de24557e 8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 10, 2024
@JornVernee JornVernee marked this pull request as ready for review January 10, 2024 17:55
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2024

Webrevs

Copy link

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (already approved in mainline)

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322324: java/foreign/TestStubAllocFailure.java times out while waiting for forked process
8322637: java/foreign/critical/TestCriticalUpcall.java timed out

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 865cf88: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable
  • 71cc879: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • 46b1b1a: 8320919: Clarify Locale related system properties
  • da24559: 8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2024
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 11, 2024

Going to push as commit db34275.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 5308410: 8321683: Tests fail with AssertionError in RangeWithPageSize
  • 6951987: 8320788: The system properties page is missing some properties
  • 3422283: 8323547: tools/jlink/plugins/SystemModuleDescriptors/ModuleMainClassTest.java fails to compile
  • dfe52be: 8323540: assert((!((((method)->is_trace_flag_set(((1 << 4) << 8))))))) failed: invariant
  • 865cf88: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable
  • 71cc879: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • 46b1b1a: 8320919: Clarify Locale related system properties
  • da24559: 8316241: Test jdk/jdk/jfr/jvm/TestChunkIntegrity.java failed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 11, 2024
@openjdk openjdk bot closed this Jan 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2024
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@JornVernee Pushed as commit db34275.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants