Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

8321582: yield <primitive-type>.class not parsed correctly. #6

Closed

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Dec 11, 2023

Hi all,

This pull request contains a backport of commit ce8399fd from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 11 Dec 2023 and was reviewed by Vicente Romero.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321582: yield <primitive-type>.class not parsed correctly. (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/jdk22.git pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/6.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2023

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ce8399fd6071766114f5f201b6e44a7abdba9f5a 8321582: yield <primitive-type>.class not parsed correctly. Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 11, 2023

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Dec 11, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321582: yield <primitive-type>.class not parsed correctly.

Reviewed-by: shade, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 9f0469b: 8320886: Unsafe_SetMemory0 is not guarded
  • 379a8bb: 8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion
  • e88a022: 8321387: SegmentAllocator:allocateFrom(AddressLayout, MemorySegment) does not throw stated UnsupportedOperationException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2023
Copy link

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahodaj
Copy link
Contributor Author

lahodaj commented Jan 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

Going to push as commit bb0e203.
Since your change was applied there have been 20 commits pushed to the master branch:

  • b121931: 8322214: Return value of XMLInputFactory.getProperty() changed from boolean to String in JDK 22 early access builds
  • a6e3565: 8321515: ARM32: Move method resolution information out of the cpCache properly
  • a72afb3: 8322647: Short name for the Europe/Lisbon time zone is incorrect
  • b8c88a3: 8321599: Data loss in AVX3 Base64 decoding
  • ea6d79f: 8322321: Add man page doc for -XX:+VerifySharedSpaces
  • c249229: 8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved
  • fb3cc98: 8321565: [REDO] Heap dump does not contain virtual Thread stack references
  • a05f3d1: 8322041: JDK 22 RDP1 L10n resource files update
  • 3ae97bc: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
  • 049be57: 8321514: UTF16 string gets constructed incorrectly from codepoints if CompactStrings is not enabled
  • ... and 10 more: https://git.openjdk.org/jdk22/compare/cbec97c945f975a13df389842ad4ab9b1bdd9878...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2024
@openjdk openjdk bot closed this Jan 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@lahodaj Pushed as commit bb0e203.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean compiler compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants