Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322971: KEM.getInstance() should check if a 3rd-party security provider is signed #61

Closed

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Jan 11, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8322974 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8322971: KEM.getInstance() should check if a 3rd-party security provider is signed (Bug - P3)
  • JDK-8322974: KEM.getInstance() should check if a 3rd-party security provider is signed (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/61/head:pull/61
$ git checkout pull/61

Update a local copy of the PR:
$ git checkout pull/61
$ git pull https://git.openjdk.org/jdk22.git pull/61/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 61

View PR using the GUI difftool:
$ git pr show -t 61

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/61.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2024

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9fd855ed477bb0849ce5c774854844deec0f4c6b 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed Jan 11, 2024
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 11, 2024
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322971: KEM.getInstance() should check if a 3rd-party security provider is signed

Reviewed-by: mullan, valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 11, 2024
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 11, 2024

Going to push as commit 4ea14b2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 11, 2024
@openjdk openjdk bot closed this Jan 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 11, 2024
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

@wangweij Pushed as commit 4ea14b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated security security-dev@openjdk.org
3 participants