Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8321685: Missing ResourceMark in code called from JvmtiEnvBase::get_vthread_jvf #64

Closed

Conversation

sspitsyn
Copy link

@sspitsyn sspitsyn commented Jan 12, 2024

Hi all,

This pull request contains a clean backport of commit 2806adee from the openjdk/jdk repository.

The commit being backported was authored by Serguei Spitsyn on 10 Jan 2024 and was reviewed by Alex Menkov and Chris Plummer.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321685: Missing ResourceMark in code called from JvmtiEnvBase::get_vthread_jvf (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/64/head:pull/64
$ git checkout pull/64

Update a local copy of the PR:
$ git checkout pull/64
$ git pull https://git.openjdk.org/jdk22.git pull/64/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 64

View PR using the GUI difftool:
$ git pr show -t 64

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/64.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2024

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2806adee2d8cca6bc215f285888631799bd02eac 8321685: Missing ResourceMark in code called from JvmtiEnvBase::get_vthread_jvf Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@sspitsyn The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jan 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321685: Missing ResourceMark in code called from JvmtiEnvBase::get_vthread_jvf

Reviewed-by: amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6022e73: 8322513: Build failure with minimal
  • 46f1df3: 8323571: Regression in source resolution process

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2024
@sspitsyn
Copy link
Author

Alex, thank you for review!

@sspitsyn
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

Going to push as commit d3f18d0.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 07a8911: 8322003: JShell - Incorrect type inference in lists of records implementing interfaces
  • 749f749: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing
  • 6022e73: 8322513: Build failure with minimal
  • 46f1df3: 8323571: Regression in source resolution process

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2024
@openjdk openjdk bot closed this Jan 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@sspitsyn Pushed as commit d3f18d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants