-
Notifications
You must be signed in to change notification settings - Fork 30
8322513: Build failure with minimal #66
8322513: Build failure with minimal #66
Conversation
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean backport of a P3 issue. Looks good.
Thanks for the review @bplb ! /integrate |
Going to push as commit 6022e73. |
@dholmes-ora Pushed as commit 6022e73. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks also @jaikiran ! |
Hi all,
This pull request contains a backport of commit 7db69e6a from the openjdk/jdk repository.
The commit being backported was authored by bobpengxie on 20 Dec 2023 and was reviewed by David Holmes and Robbin Ehn.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/66/head:pull/66
$ git checkout pull/66
Update a local copy of the PR:
$ git checkout pull/66
$ git pull https://git.openjdk.org/jdk22.git pull/66/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 66
View PR using the GUI difftool:
$ git pr show -t 66
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/66.diff
Webrev
Link to Webrev Comment