Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned #72

Closed

Conversation

AlanBateman
Copy link

@AlanBateman AlanBateman commented Jan 13, 2024

Clean backport of P3 issue JDK-8322818. The test was initially problematic so I have to include the test-only fixes JDK-8323002 and JDK-8323296 (doing these as follow-on or dependent PRs wouldn't guarantee that would integrate at the same time).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned (Bug - P3)
  • JDK-8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64 (Bug - P4)
  • JDK-8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/72/head:pull/72
$ git checkout pull/72

Update a local copy of the PR:
$ git checkout pull/72
$ git pull https://git.openjdk.org/jdk22.git pull/72/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 72

View PR using the GUI difftool:
$ git pr show -t 72

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/72.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2024

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4db7a1c3bb6b56cc7416aa27350406da27fe04a8 8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned Jan 13, 2024
@openjdk
Copy link

openjdk bot commented Jan 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 13, 2024

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 13, 2024
@openjdk openjdk bot removed the clean label Jan 13, 2024
@AlanBateman
Copy link
Author

/issue add JDK-8323002
/issue add JDK-8323296

@openjdk
Copy link

openjdk bot commented Jan 13, 2024

@AlanBateman
Adding additional issue to issue list: 8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64.

@openjdk
Copy link

openjdk bot commented Jan 13, 2024

@AlanBateman
Adding additional issue to issue list: 8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out.

@AlanBateman AlanBateman marked this pull request as ready for review January 15, 2024 09:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 15, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 15, 2024

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned
8323002: test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java times out on macosx-x64
8323296: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java#id1 timed out

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8db5d86: 8323008: filter out harmful -std* flags added by autoconf from CXX
  • ba96094: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2024
@AlanBateman
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

Going to push as commit 628e31b.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3017281: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 8db5d86: 8323008: filter out harmful -std* flags added by autoconf from CXX
  • ba96094: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2024
@openjdk openjdk bot closed this Jan 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2024
@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@AlanBateman Pushed as commit 628e31b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants