Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8323243: JNI invocation of an abstract instance method corrupts the stack #73

Closed

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jan 14, 2024

Hi all,

This pull request contains a backport of commit 71d9a83d from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 14 Jan 2024 and was reviewed by Coleen Phillimore and Aleksey Shipilev.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323243: JNI invocation of an abstract instance method corrupts the stack (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/73/head:pull/73
$ git checkout pull/73

Update a local copy of the PR:
$ git checkout pull/73
$ git pull https://git.openjdk.org/jdk22.git pull/73/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 73

View PR using the GUI difftool:
$ git pr show -t 73

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/73.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 71d9a83dece7eb4bdb6ffdd9caf14a1348045ce0 8323243: JNI invocation of an abstract instance method corrupts the stack Jan 14, 2024
@openjdk
Copy link

openjdk bot commented Jan 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 14, 2024
@openjdk
Copy link

openjdk bot commented Jan 14, 2024

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 14, 2024

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it as the backport is clean.

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323243: JNI invocation of an abstract instance method corrupts the stack

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 247a436: 8323651: compiler/c2/irTests/TestPrunedExHandler.java fails with -XX:+DeoptimizeALot
  • 4799c8d: 8323631: JfrTypeSet::write_klass can enqueue a CLD klass that is unloading
  • bb43aae: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • 4034787: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME
  • a91569d: 8322957: Generational ZGC: Relocation selection must join the STS
  • 9257505: 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if
  • 628e31b: 8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned
  • 3017281: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 8db5d86: 8323008: filter out harmful -std* flags added by autoconf from CXX
  • ba96094: 8323610: G1: HeapRegion pin count should be size_t to avoid overflows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2024
@dholmes-ora
Copy link
Member Author

Thanks @iklam !

/integrate

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

Going to push as commit b40b188.
Since your change was applied there have been 12 commits pushed to the master branch:

  • c1ea6da: 8323659: LinkedTransferQueue add and put methods call overridable offer
  • b9a535b: 8322235: Split up and improve LocaleProvidersRun
  • 247a436: 8323651: compiler/c2/irTests/TestPrunedExHandler.java fails with -XX:+DeoptimizeALot
  • 4799c8d: 8323631: JfrTypeSet::write_klass can enqueue a CLD klass that is unloading
  • bb43aae: 8322330: JavadocHelperTest.java OOMEs with Parallel GC and ZGC
  • 4034787: 8322987: Remove gc/stress/gclocker/TestGCLocker* since they always fail with OOME
  • a91569d: 8322957: Generational ZGC: Relocation selection must join the STS
  • 9257505: 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if
  • 628e31b: 8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned
  • 3017281: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • ... and 2 more: https://git.openjdk.org/jdk22/compare/01f780fab21aceed5f40baeb6d4fa832bfee8251...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2024
@openjdk openjdk bot closed this Jan 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@dholmes-ora Pushed as commit b40b188.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants