Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if #76

Closed

Conversation

chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Jan 15, 2024

Hi all,

This pull request contains a backport of commit 7e0a4ed6 from the openjdk/jdk repository.

The commit being backported was authored by Christian Hagedorn on 15 Jan 2024 and was reviewed by Vladimir Kozlov and Tobias Hartmann.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/76/head:pull/76
$ git checkout pull/76

Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.org/jdk22.git pull/76/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 76

View PR using the GUI difftool:
$ git pr show -t 76

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/76.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2024

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7e0a4ed6292586772c23292dbdd67ed1db5c12f7 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@chhagedorn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 15, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 15, 2024

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 15, 2024
@chhagedorn
Copy link
Member Author

Thanks Tobias for your review!

@chhagedorn
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

Going to push as commit 9257505.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 628e31b: 8322818: Thread::getStackTrace can fail with InternalError if virtual thread is timed-parked when pinned
  • 3017281: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 8db5d86: 8323008: filter out harmful -std* flags added by autoconf from CXX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2024
@openjdk openjdk bot closed this Jan 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2024
@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@chhagedorn Pushed as commit 9257505.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants