8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader

[calvinccheung]

Hi all,

This pull request contains a backport of commit 841ab487 from the openjdk/jdk repository.

The commit being backported was authored by Calvin Cheung on 8 Jan 2024 and was reviewed by Matias Saavedra Silva and David Holmes.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader (Bug - P3)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/85/head:pull/85
$ git checkout pull/85

Update a local copy of the PR:
$ git checkout pull/85
$ git pull https://git.openjdk.org/jdk22.git pull/85/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 85

View PR using the GUI difftool:
$ git pr show -t 85

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/85.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8208e795)

[dholmes-ora]

Looks good. Thanks

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• b40b188: 8323243: JNI invocation of an abstract instance method corrupts the stack
• c1ea6da: 8323659: LinkedTransferQueue add and put methods call overridable offer

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

Thanks @dholmes-ora for the review!

/integrate

[openjdk]

Going to push as commit f9f7a27.
Since your change was applied there have been 15 commits pushed to the master branch:

• 60c68a1: 8322512: StringBuffer.repeat does not work correctly after toString() was called
• 78150ca: 8316756: C2 EA fails with "missing memory path" when encountering unsafe_arraycopy stub call
• 887a93b: 8323159: Consider adding some text re. memory zeroing in Arena::allocate
• eb2c4b0: 8320175: [BACKOUT] 8316533: C2 compilation fails with assert(verify(phase)) failed: missing Value() optimization
• b2cc189: Merge
• c7f1c97: 8317547: Enhance TLS connection support
• 7fc13bb: 8314307: Improve loop handling
• 175184c: 8318588: Windows build failure after JDK-8314468 due to ambiguous call
• dfea48b: 8314468: Improve Compiler loops
• 83f0f84: 8317331: Solaris build failed with "declaration can not follow a statement (E_DECLARATION_IN_CODE)"
• ... and 5 more: https://git.openjdk.org/jdk22/compare/b9a535b8ac2e7bd5c7c2e56c1b0a498fa9c94d2a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit f9f7a27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.