8322512: StringBuffer.repeat does not work correctly after toString() was called

[JimLaskey]

The new repeat methods were not clearing the toStringCache.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322512: StringBuffer.repeat does not work correctly after toString() was called (Bug - P3)

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)
• Claes Redestad (@cl4es - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/87/head:pull/87
$ git checkout pull/87

Update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.org/jdk22.git pull/87/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 87

View PR using the GUI difftool:
$ git pr show -t 87

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/87.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[pavelrappo]

Seems like a clean backport of a P3 bug from mainline to jdk 22, just in time before RDP 2.

[mlbridge]

Webrevs

• 01: Full - Incremental (0ae24358)
• 00: Full (e9817489)

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322512: StringBuffer.repeat does not work correctly after toString() was called

Reviewed-by: prappo, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pavelrappo]

Jim, note that the bot said this:

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

I'm not sure why there's such a big divergence, but if I were you, I'd be testing this change extra carefully before integrating.

[JimLaskey]

/integrate

[openjdk]

Going to push as commit 60c68a1.

[openjdk]

@JimLaskey Pushed as commit 60c68a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.