Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion#9

Closed
tschatzl wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-tschatzl-7d903964
Closed

8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion#9
tschatzl wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-tschatzl-7d903964

Conversation

@tschatzl
Copy link

@tschatzl tschatzl commented Dec 12, 2023

(Description copied from original PR)

Hi all,

please review this change that disables core file creation for the subtests of this test that check for assertion failure. Core dump creation can make the whole test time out.

----------System.out:(54/8466)----------
Command line:... -XX:+UseG1GC -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:. -Xmx32M -Xmn16M -Xlog:gc gc.g1.pinnedobjs.TestObjectPin Object ]
[2023-12-05T23:30:37.930237Z] Gathering output for process 98165
[0.066s][info][gc] Using G1
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/open/src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp:268), pid=98165, tid=6403
#  assert(obj->is_typeArray()) failed: must be typeArray
#[...]
# If you would like to submit a bug report, please visit:
#   https://bugreport.java.com/bugreport/crash.jsp
#

[2023-12-05T23:35:20.308715Z] Waiting for completion for process 98165
[2023-12-05T23:35:20.632162Z] Waiting for completion finished for process 98165

Notice the 5 min delay from the Gathering output for process to the Waiting for completion finished message. This repeats for the second test, triggering the timeout.

Testing: failing test

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/9/head:pull/9
$ git checkout pull/9

Update a local copy of the PR:
$ git checkout pull/9
$ git pull https://git.openjdk.org/jdk22.git pull/9/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9

View PR using the GUI difftool:
$ git pr show -t 9

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/9.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7d903964fb1b8840664d4f0f9a4fa1a53111a856 8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 12, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2023

Webrevs

@tschatzl
Copy link
Author

/approval request Fix Request 22

Backporting this patch eliminates test noise by improving a test.
Low risk as this only touches tests.
Patch applies cleanly to 22.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@tschatzl Changes in this repository do not require maintainer approval.

@tschatzl
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@tschatzl This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2023
@tschatzl
Copy link
Author

Thank @walulyai @albertnetymk for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

Going to push as commit 379a8bb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2023
@openjdk openjdk bot closed this Dec 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@tschatzl Pushed as commit 379a8bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants