8321422: Test gc/g1/pinnedobjs/TestPinnedObjectTypes.java times out after completion#9
Conversation
|
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Fix Request 22 Backporting this patch eliminates test noise by improving a test. |
|
@tschatzl Changes in this repository do not require maintainer approval. |
|
/integrate |
|
@tschatzl This pull request has not yet been marked as ready for integration. |
|
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thank @walulyai @albertnetymk for your reviews |
|
Going to push as commit 379a8bb. |
(Description copied from original PR)
Hi all,
please review this change that disables core file creation for the subtests of this test that check for assertion failure. Core dump creation can make the whole test time out.
Notice the 5 min delay from the
Gathering output for processto theWaiting for completion finishedmessage. This repeats for the second test, triggering the timeout.Testing: failing test
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/9/head:pull/9$ git checkout pull/9Update a local copy of the PR:
$ git checkout pull/9$ git pull https://git.openjdk.org/jdk22.git pull/9/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9View PR using the GUI difftool:
$ git pr show -t 9Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/9.diff
Webrev
Link to Webrev Comment