-
Notifications
You must be signed in to change notification settings - Fork 30
8324688: C2: Disable ReduceAllocationMerges by default #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into |
@chhagedorn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@chhagedorn The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Thanks Tobias for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I approved this fix request for JDK 22.
LGTM! |
Thanks Vladimir for the approval and for the review! |
/integrate |
@chhagedorn Pushed as commit b7f38fc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Due to several recent bug reports after the integration of JDK-8287061 in JDK 22 (latest one being JDK-8322854), we've decided together with @JohnTortugo that we want to minimize the risk and that it's best to disable
ReduceAllocationMerges
by default for JDK 22 which disables the optimizations of JDK-8287061.Thanks,
Christian
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/97/head:pull/97
$ git checkout pull/97
Update a local copy of the PR:
$ git checkout pull/97
$ git pull https://git.openjdk.org/jdk22.git pull/97/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 97
View PR using the GUI difftool:
$ git pr show -t 97
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/97.diff
Webrev
Link to Webrev Comment