-
Notifications
You must be signed in to change notification settings - Fork 57
8322503: Shenandoah: Clarify gc state usage #101
8322503: Shenandoah: Clarify gc state usage #101
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This is a follow up to JDK-8321815. It renames methods, improves comments, and adds an assert. I believe the risk is low. I also believe these GHA failures are unrelated to this change. |
@earthling-amzn |
/integrate |
@earthling-amzn |
/sponsor |
Going to push as commit afce5e6.
Your commit was automatically rebased without conflicts. |
@shipilev @earthling-amzn Pushed as commit afce5e6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. This is a follow up to https://bugs.openjdk.org/browse/JDK-8321815, which renames methods and changes comments and adds an assert for improved readability.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/101/head:pull/101
$ git checkout pull/101
Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.org/jdk22u.git pull/101/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 101
View PR using the GUI difftool:
$ git pr show -t 101
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/101.diff
Webrev
Link to Webrev Comment