Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 #102

Closed

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 15, 2024


Progress

  • JDK-8327040 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/102/head:pull/102
$ git checkout pull/102

Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.org/jdk22u.git pull/102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 102

View PR using the GUI difftool:
$ git pr show -t 102

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/102.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • afce5e6: 8322503: Shenandoah: Clarify gc state usage
  • 6c2eefc: 8326529: JFR: Test for CompilerCompile events fails due to time out
  • 2ec72f9: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0d354503620eb7f6da7b1b8aa6143ba18ced8f12 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14 Mar 15, 2024
@openjdk
Copy link

openjdk bot commented Mar 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 15, 2024

⚠️ @prsadhuk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 15, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 15, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

Going to push as commit 98ea70d.
Since your change was applied there have been 3 commits pushed to the master branch:

  • afce5e6: 8322503: Shenandoah: Clarify gc state usage
  • 6c2eefc: 8326529: JFR: Test for CompilerCompile events fails due to time out
  • 2ec72f9: 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2024
@openjdk openjdk bot closed this Mar 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@prsadhuk Pushed as commit 98ea70d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant