Skip to content
This repository was archived by the owner on Jul 17, 2024. It is now read-only.

8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection #103

Closed
wants to merge 1 commit into from

Conversation

pkumaraswamy
Copy link

@pkumaraswamy pkumaraswamy commented Mar 18, 2024

This is a clean backport.

I have verified the fix and results are attached here
x509_testing.zip


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312383 needs maintainer approval

Issue

  • JDK-8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/103/head:pull/103
$ git checkout pull/103

Update a local copy of the PR:
$ git checkout pull/103
$ git pull https://git.openjdk.org/jdk22u.git pull/103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 103

View PR using the GUI difftool:
$ git pr show -t 103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/103.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@pkumaraswamy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport bdd1aebea379b63ae405827074530ef8e8a7c239 8312383: Log X509ExtendedKeyManager implementation class name in TLS/SSL connection Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2024

Webrevs

@pkumaraswamy
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@pkumaraswamy
Your change (at version 410af50) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Mar 18, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

Going to push as commit 2ec72f9.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2024
@openjdk openjdk bot closed this Mar 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@coffeys @pkumaraswamy Pushed as commit 2ec72f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants