Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size #11

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 8, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322098 needs maintainer approval

Issue

  • JDK-8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/jdk22u.git pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/11.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b31454e36234091c3827c3b4d07f62345cb0cee4 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 9e1e6e1: 8321480: ISO 4217 Amendment 176 Update
  • 648ebea: Merge
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 6aace18: 8319948: jcmd man page needs to be updated
  • 28279ee: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • 01cb043: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • ... and 14 more: https://git.openjdk.org/jdk22u/compare/75f52ea0b2a6b69cac7633803c3d2dfe7d6bbd6a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 9, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2024

Going to push as commit 3257d9d.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 4c8b839: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • 484138e: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • 9e1e6e1: 8321480: ISO 4217 Amendment 176 Update
  • 648ebea: Merge
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 6aace18: 8319948: jcmd man page needs to be updated
  • ... and 16 more: https://git.openjdk.org/jdk22u/compare/75f52ea0b2a6b69cac7633803c3d2dfe7d6bbd6a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2024
@openjdk openjdk bot closed this Jan 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

@MBaesken Pushed as commit 3257d9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant