-
Notifications
You must be signed in to change notification settings - Fork 57
8326521: JFR: CompilerPhase event test fails on windows 32 bit #112
8326521: JFR: CompilerPhase event test fails on windows 32 bit #112
Conversation
👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into |
@roberttoyonaga This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for the backport of a JFR test case fix. Should be very low risk. Clean backport. |
@roberttoyonaga |
/integrate |
@roberttoyonaga |
/sponsor |
Going to push as commit 22230b3.
Your commit was automatically rebased without conflicts. |
@jerboaa @roberttoyonaga Pushed as commit 22230b3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of openjdk/jdk@96530bc
On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test
TestCompilerPhase
fails on some systems because it cannot generate the necessary CompilerPhase JFR events .This backport prevents
NeverActAsServerClassMachine
from being set during the testTestCompilerPhase
, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3045).Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/112/head:pull/112
$ git checkout pull/112
Update a local copy of the PR:
$ git checkout pull/112
$ git pull https://git.openjdk.org/jdk22u.git pull/112/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 112
View PR using the GUI difftool:
$ git pr show -t 112
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/112.diff
Webrev
Link to Webrev Comment