Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8326521: JFR: CompilerPhase event test fails on windows 32 bit #112

Conversation

roberttoyonaga
Copy link
Contributor

@roberttoyonaga roberttoyonaga commented Mar 22, 2024

This is a backport of openjdk/jdk@96530bc

On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test TestCompilerPhase fails on some systems because it cannot generate the necessary CompilerPhase JFR events .

This backport prevents NeverActAsServerClassMachine from being set during the test TestCompilerPhase, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3045).


Progress

  • Change must not contain extraneous whitespace
  • JDK-8326521 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8326521: JFR: CompilerPhase event test fails on windows 32 bit (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/112/head:pull/112
$ git checkout pull/112

Update a local copy of the PR:
$ git checkout pull/112
$ git pull https://git.openjdk.org/jdk22u.git pull/112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 112

View PR using the GUI difftool:
$ git pr show -t 112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/112.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@roberttoyonaga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326521: JFR: CompilerPhase event test fails on windows 32 bit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
  • e2d6c5e: 8328825: Google CAInterop test failures
  • 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • f2e1be5: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • 8888745: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • ba80d42: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960
  • 2c00048: 8328812: Update and move siphash license
  • dcca5da: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185
  • 14bd76f: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 96530bcc07514c3eda40fd6ffa74f197fe541dea 8326521: JFR: CompilerPhase event test fails on windows 32 bit Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

This backport pull request has now been updated with issue from the original commit.

@roberttoyonaga roberttoyonaga marked this pull request as ready for review March 22, 2024 20:13
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

@roberttoyonaga
Copy link
Contributor Author

/approval request for the backport of a JFR test case fix. Should be very low risk. Clean backport.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@roberttoyonaga
8326521: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 26, 2024
@roberttoyonaga
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@roberttoyonaga
Your change (at version fa72ceb) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Apr 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

Going to push as commit 22230b3.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 3d6bd8e: 8328604: remove on_aix() function
  • 92d6fa4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
  • 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
  • 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • 95772e6: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 5d7f7da: 8325567: jspawnhelper without args fails with segfault
  • 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
  • 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
  • aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
  • ... and 9 more: https://git.openjdk.org/jdk22u/compare/089aad7d94566d1ba708e47d04e1b3e9fd487aa3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 9, 2024
@openjdk openjdk bot closed this Apr 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@jerboaa @roberttoyonaga Pushed as commit 22230b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants