8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8325579, commit 907e30ff from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 25 Mar 2024 and was reviewed by Daniel Fuchs and Aleksei Efimov.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325579 needs maintainer approval
• Change requires CSR request JDK-8326482 to be approved

Issues

• JDK-8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (Bug - P3 - Approved)
• JDK-8326482: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/114/head:pull/114
$ git checkout pull/114

Update a local copy of the PR:
$ git checkout pull/114
$ git pull https://git.openjdk.org/jdk22u.git pull/114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 114

View PR using the GUI difftool:
$ git pr show -t 114

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/114.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
• aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
• e2d6c5e: 8328825: Google CAInterop test failures
• 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
• 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
• f2e1be5: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
• 8888745: 8328705: GHA: Cross-compilation jobs do not require build JDK
• ba80d42: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960
• 2c00048: 8328812: Update and move siphash license

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (2930d93d)

[RealCLanger]

/approval request Requesting approval for this consistency fix in the LDAP client. It has a CSR attached that was approved for the backport releases already when we did this in head. Tests pass, both GHA and SAP testing.

[openjdk]

@RealCLanger
8325579: The approval request has been created successfully.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 92d6fa4.
Since your change was applied there have been 15 commits pushed to the master branch:

• 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
• 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
• 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
• 95772e6: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
• 5d7f7da: 8325567: jspawnhelper without args fails with segfault
• 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
• 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
• aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
• e2d6c5e: 8328825: Google CAInterop test failures
• 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
• ... and 5 more: https://git.openjdk.org/jdk22u/compare/dcca5daaf7f51c6579369c6ba3430a3d7962dbf2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 92d6fa4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.