Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

JDK-8328988 : [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653 #116

Closed
wants to merge 1 commit into from

Conversation

honkar-jdk
Copy link

@honkar-jdk honkar-jdk commented Mar 26, 2024

The following test, java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java fails on macOS 14 on jdk22 & older. The reason for failure on macOS 14 is documented here - JDK-8322653.

Since CI testing is being extended to run on macOS 14, it is necessary to problem-list this test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328988 needs maintainer approval

Issue

  • JDK-8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/116/head:pull/116
$ git checkout pull/116

Update a local copy of the PR:
$ git checkout pull/116
$ git pull https://git.openjdk.org/jdk22u.git pull/116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 116

View PR using the GUI difftool:
$ git pr show -t 116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/116.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2024

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • f2e1be5: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • 8888745: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • ba80d42: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2024
@honkar-jdk
Copy link
Author

/label client

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@honkar-jdk
The label client is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Mar 26, 2024

Webrevs

@honkar-jdk
Copy link
Author

@prrace Can you please approve this problem-listing PR when you get a chance?

@openjdk openjdk bot added approval and removed approval labels Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

⚠️ @honkar-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Mar 26, 2024
@honkar-jdk
Copy link
Author

/approval JDK-8328988 request java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java is being problem-listed since it fails on macOS 14 on jdk22u. Since CI testing is being extended to macOS 14, it is necessary to problem-list this test. Low risk fix which involves problem-listing the test.
The test fails on jdk22u & older but not mainline hence the problemlisted PR is created against jdk-22u.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@honkar-jdk
JDK-8328988: The approval request has been created successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 2, 2024
@honkar-jdk
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@honkar-jdk
Your change (at version 1097286) is now ready to be sponsored by a Committer.

@honkar-jdk
Copy link
Author

@prrace Can you please sponsor this PR?

@prrace
Copy link
Contributor

prrace commented Apr 4, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

Going to push as commit 2374d1e.
Since your change was applied there have been 7 commits pushed to the master branch:

  • aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
  • e2d6c5e: 8328825: Google CAInterop test failures
  • 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • f2e1be5: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • 8888745: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • ba80d42: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2024
@openjdk openjdk bot closed this Apr 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@prrace @honkar-jdk Pushed as commit 2374d1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
2 participants