Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8323801: <s> tag doesn't strikethrough the text #117

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Mar 29, 2024

Backport JDK-8323801: <s> tag doesn't strikethrough the text. The patch applies cleanly.


Progress

  • JDK-8323801 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323801: <s> tag doesn't strikethrough the text (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/117/head:pull/117
$ git checkout pull/117

Update a local copy of the PR:
$ git checkout pull/117
$ git pull https://git.openjdk.org/jdk22u.git pull/117/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 117

View PR using the GUI difftool:
$ git pr show -t 117

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/117.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 29, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323801: <s> tag doesn't strikethrough the text

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • dbaca7a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
  • 98a63a8: 8328589: unify os::breakpoint among posix platforms
  • 22230b3: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 3d6bd8e: 8328604: remove on_aix() function
  • 92d6fa4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
  • 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
  • 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • ... and 9 more: https://git.openjdk.org/jdk22u/compare/88887450a075ef987e08a2088c5513f55223f60a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 80b63b67293970936d57ae4375ad76cd2b11a333 8323801: <s> tag doesn't strikethrough the text Mar 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 29, 2024

⚠️ @aivanov-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 29, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 29, 2024
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 17, 2024

Going to push as commit ae466e2.
Since your change was applied there have been 24 commits pushed to the master branch:

  • c45dbbc: 8327631: Update IANA Language Subtag Registry to Version 2024-03-07
  • 11adb6e: 8329656: assertion failed in MAP_ARCHIVE_MMAP_FAILURE path: Invalid immediate -5 0
  • 3d99b8f: 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC
  • 64b4949: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
  • bcf0d25: 8329823: RISC-V: Need to sync CPU features with related JVM flags
  • dbaca7a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
  • 98a63a8: 8328589: unify os::breakpoint among posix platforms
  • 22230b3: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • ... and 14 more: https://git.openjdk.org/jdk22u/compare/88887450a075ef987e08a2088c5513f55223f60a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2024
@openjdk openjdk bot closed this Apr 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2024
@openjdk
Copy link

openjdk bot commented Apr 17, 2024

@aivanov-jdk Pushed as commit ae466e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the backport-aivanov-jdk-80b63b67 branch April 17, 2024 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant