Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328316: Finisher cannot emit if stream is sequential and integrator returned false #118

Conversation

viktorklang-ora
Copy link

@viktorklang-ora viktorklang-ora commented Apr 2, 2024

Hi all,

This pull request contains a backport of commit ab28045d from the openjdk/jdk repository addressing JDK-8328316.

The commit being backported was authored by Viktor Klang on 21 Mar 2024 and was reviewed by Paul Sandoz.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328316 needs maintainer approval

Issue

  • JDK-8328316: Finisher cannot emit if stream is sequential and integrator returned false (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/118/head:pull/118
$ git checkout pull/118

Update a local copy of the PR:
$ git checkout pull/118
$ git pull https://git.openjdk.org/jdk22u.git pull/118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 118

View PR using the GUI difftool:
$ git pr show -t 118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/118.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2024

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328316: Finisher cannot emit if stream is sequential and integrator returned false

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • dbaca7a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
  • 98a63a8: 8328589: unify os::breakpoint among posix platforms
  • 22230b3: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 3d6bd8e: 8328604: remove on_aix() function
  • 92d6fa4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
  • 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
  • 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • ... and 9 more: https://git.openjdk.org/jdk22u/compare/88887450a075ef987e08a2088c5513f55223f60a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ab28045d7785d948b2bce685f06043e8217961f4 8328316: Finisher cannot emit if stream is sequential and integrator returned false Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Apr 2, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 10, 2024
@viktorklang-ora
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@viktorklang-ora
Your change (at version a078f82) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

Going to push as commit 64b4949.
Since your change was applied there have been 20 commits pushed to the master branch:

  • bcf0d25: 8329823: RISC-V: Need to sync CPU features with related JVM flags
  • dbaca7a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
  • 98a63a8: 8328589: unify os::breakpoint among posix platforms
  • 22230b3: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 3d6bd8e: 8328604: remove on_aix() function
  • 92d6fa4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
  • 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
  • ... and 10 more: https://git.openjdk.org/jdk22u/compare/88887450a075ef987e08a2088c5513f55223f60a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2024
@openjdk openjdk bot closed this Apr 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@AlanBateman @viktorklang-ora Pushed as commit 64b4949.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants