Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8319548: Unexpected internal name for Filler array klass causes error in VisualVM #119

Conversation

ChrisHegarty
Copy link
Member

@ChrisHegarty ChrisHegarty commented Apr 2, 2024

Hi all,

This pull request contains a backport of commit 05745e3f from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 21 Dec 2023 and was reviewed by Albert Mingkun Yang and David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319548 needs maintainer approval

Issue

  • JDK-8319548: Unexpected internal name for Filler array klass causes error in VisualVM (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/119/head:pull/119
$ git checkout pull/119

Update a local copy of the PR:
$ git checkout pull/119
$ git pull https://git.openjdk.org/jdk22u.git pull/119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 119

View PR using the GUI difftool:
$ git pr show -t 119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/119.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2024

👋 Welcome back chegar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@ChrisHegarty This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319548: Unexpected internal name for Filler array klass causes error in VisualVM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e2d6c5e: 8328825: Google CAInterop test failures
  • 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 05745e3f1d56f71d7647e81fa5933c9f4ed18430 8319548: Unexpected internal name for Filler array klass causes error in VisualVM Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

⚠️ @ChrisHegarty This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 2, 2024
@ChrisHegarty
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

Going to push as commit aead789.
Since your change was applied there have been 3 commits pushed to the master branch:

  • e2d6c5e: 8328825: Google CAInterop test failures
  • 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2024
@openjdk openjdk bot closed this Apr 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@ChrisHegarty Pushed as commit aead789.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant