Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8328825: Google CAInterop test failures #120

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 2, 2024

Clean backport to fix some of the current failures in CAInterop test.

Additional testing:

  • Affected subtests are now passing

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328825 needs maintainer approval

Issue

  • JDK-8328825: Google CAInterop test failures (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/120/head:pull/120
$ git checkout pull/120

Update a local copy of the PR:
$ git checkout pull/120
$ git pull https://git.openjdk.org/jdk22u.git pull/120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 120

View PR using the GUI difftool:
$ git pr show -t 120

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/120.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

shipilev commented Apr 2, 2024

/approval request Clean backport to fix some of the current failures in CAInterop test. Applies cleanly. Affected test passes with higher success rate, there are still some subtests that need to be fixed separately. Risk is low, test-only change, fixes the already broken test.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328825: Google CAInterop test failures

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624 8328825: Google CAInterop test failures Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev
8328825: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 2, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 2, 2024
@shipilev
Copy link
Member Author

shipilev commented Apr 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

Going to push as commit e2d6c5e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 5cb863d: 8324646: Avoid Class.forName in SecureRandom constructor
  • 39948e5: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2024
@openjdk openjdk bot closed this Apr 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@shipilev Pushed as commit e2d6c5e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant