Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328709: AIX os::get_summary_cpu_info support Power 10 #122

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 3, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328709 needs maintainer approval

Issue

  • JDK-8328709: AIX os::get_summary_cpu_info support Power 10 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/122/head:pull/122
$ git checkout pull/122

Update a local copy of the PR:
$ git checkout pull/122
$ git pull https://git.openjdk.org/jdk22u.git pull/122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 122

View PR using the GUI difftool:
$ git pr show -t 122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/122.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328709: AIX os::get_summary_cpu_info  support Power 10

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 95772e6: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 5d7f7da: 8325567: jspawnhelper without args fails with segfault
  • 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
  • 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
  • aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b235682a18653ab16f2d9b03b1e55698a91273b7 8328709: AIX os::get_summary_cpu_info support Power 10 Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Apr 3, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 3, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 4, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Apr 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit 8f0f42b.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • 95772e6: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 5d7f7da: 8325567: jspawnhelper without args fails with segfault
  • 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
  • 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
  • aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@MBaesken Pushed as commit 8f0f42b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant