Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328702: C2: Crash during parsing because sub type check is not folded #125

Closed

Conversation

chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Apr 4, 2024

Hi all,

This pull request contains a backport of commit e5e21a8a from the openjdk/jdk repository.

The commit being backported was authored by Christian Hagedorn on 4 Apr 2024 and was reviewed by Roland Westrelin and Vladimir Kozlov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8328702 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8328702: C2: Crash during parsing because sub type check is not folded (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/125/head:pull/125
$ git checkout pull/125

Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.org/jdk22u.git pull/125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 125

View PR using the GUI difftool:
$ git pr show -t 125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/125.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2024

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328702: C2: Crash during parsing because sub type check is not folded

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 22230b3: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 3d6bd8e: 8328604: remove on_aix() function
  • 92d6fa4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • 20d95c5: 8327468: Do not restart close if errno is EINTR [macOS/linux]
  • 8f0f42b: 8328709: AIX os::get_summary_cpu_info support Power 10
  • 083f9d1: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • 95772e6: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 5d7f7da: 8325567: jspawnhelper without args fails with segfault
  • 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
  • 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
  • ... and 1 more: https://git.openjdk.org/jdk22u/compare/e2d6c5ec6211ef59d76f699d06888d404cfd9cb4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e5e21a8a6e64466f9cda2064aa2723a15d4ae86a 8328702: C2: Crash during parsing because sub type check is not folded Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

⚠️ @chhagedorn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 4, 2024
@chhagedorn
Copy link
Member Author

Thanks Tobias for your review!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

Going to push as commit 817cf13.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2024
@openjdk openjdk bot closed this Apr 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@chhagedorn Pushed as commit 817cf13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants