8325567: jspawnhelper without args fails with segfault

[shipilev]

Clean backport to improve jspawnhelper resiliency and provide the grounds for later backports.

Additional testing:

• jspawnhelper no longer SEGVs when ran manually
• java/lang/ProcessBuilder tests pass, including new test

---

Progress

• Change must not contain extraneous whitespace
• JDK-8325567 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8325567: jspawnhelper without args fails with segfault (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/126/head:pull/126
$ git checkout pull/126

Update a local copy of the PR:
$ git checkout pull/126
$ git pull https://git.openjdk.org/jdk22u.git pull/126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 126

View PR using the GUI difftool:
$ git pr show -t 126

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/126.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[shipilev]

/approval request Clean backport to improve jspawnhelper resiliency and provide the grounds for later backports. Relevant tests pass, including the new test. Risk is low: touches the production code paths, but in simple manner.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325567: jspawnhelper without args fails with segfault

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
• aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@shipilev
8325567: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (2cdfd030)

[shipilev]

/integrate

[openjdk]

Going to push as commit 5d7f7da.
Since your change was applied there have been 3 commits pushed to the master branch:

• 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
• 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
• aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 5d7f7da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.