Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8329013: StackOverflowError when starting Apache Tomcat with signed jar #129

Closed

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented Apr 4, 2024

Clean backport. jdk_security testing is green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329013 needs maintainer approval

Issue

  • JDK-8329013: StackOverflowError when starting Apache Tomcat with signed jar (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/129/head:pull/129
$ git checkout pull/129

Update a local copy of the PR:
$ git checkout pull/129
$ git pull https://git.openjdk.org/jdk22u.git pull/129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 129

View PR using the GUI difftool:
$ git pr show -t 129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/129.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2024

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329013: StackOverflowError when starting Apache Tomcat with signed jar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
  • aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 925d82931c09dc11ea5a3bc410ea5cfd67ee14aa 8329013: StackOverflowError when starting Apache Tomcat with signed jar Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2024
@coffeys
Copy link
Contributor Author

coffeys commented Apr 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

Going to push as commit 95772e6.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 5d7f7da: 8325567: jspawnhelper without args fails with segfault
  • 8d7d8a4: 8328638: Fallback option for POST-only OCSP requests
  • 2374d1e: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
  • aead789: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2024
@openjdk openjdk bot closed this Apr 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@coffeys Pushed as commit 95772e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 4, 2024

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant