Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.
/ jdk22u Public archive

8322725: (tz) Update Timezone Data to 2023d#13

Closed
johnyjose30 wants to merge 1 commit intoopenjdk:masterfrom
johnyjose30:JDK-8323080
Closed

8322725: (tz) Update Timezone Data to 2023d#13
johnyjose30 wants to merge 1 commit intoopenjdk:masterfrom
johnyjose30:JDK-8323080

Conversation

@johnyjose30
Copy link
Contributor

@johnyjose30 johnyjose30 commented Jan 9, 2024

Clean backport of openjdk/jdk@2a9c358


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322725 needs maintainer approval

Issue

  • JDK-8322725: (tz) Update Timezone Data to 2023d (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/13/head:pull/13
$ git checkout pull/13

Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jdk22u.git pull/13/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13

View PR using the GUI difftool:
$ git pr show -t 13

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/13.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @johnyjose30 could not find any commit with hash 745a2ad5c7c4c9e9210bff47493195348de3d21b. Please update the title with the hash for an existing commit.

@johnyjose30 johnyjose30 changed the title Backport 745a2ad5c7c4c9e9210bff47493195348de3d21b Backport 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc Jan 9, 2024
@openjdk openjdk bot changed the title Backport 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc 8322725: (tz) Update Timezone Data to 2023d Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @johnyjose30 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322725: (tz) Update Timezone Data to 2023d

Reviewed-by: coffeys, naoto
Backport-of: 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • beb35a8: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
  • 136180b: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 512cd87: 8322417: Console read line with zero out should zero out when throwing exception

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@johnyjose30
Copy link
Contributor Author

/reviewer credit @coffeys @naotoj

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@johnyjose30
Reviewer coffeys successfully credited.

Reviewer naoto successfully credited.

@johnyjose30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@johnyjose30
Your change (at version 11fd9c3) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Jan 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 07df9e3.
Since your change was applied there have been 3 commits pushed to the master branch:

  • beb35a8: 8322163: runtime/Unsafe/InternalErrorTest.java fails on Alpine after JDK-8320886
  • 136180b: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 512cd87: 8322417: Console read line with zero out should zero out when throwing exception

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@coffeys @johnyjose30 Pushed as commit 07df9e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants