8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin

[reinrich]

Hi,

this PR contains a backport of commit openjdk/jdk@4018b2b.

I'd like to do the backport because jdk 22 is affected by the issue. The included test hangs without the change.
Besides it will reduce the noise in jck tests we're doing regularly (the test api/java_net/ServerSocket/AcceptInterruptibleTests_PlatformThreads fails sometimes because of the issue).

The original fix does not apply due to renaming of a local variable. Also the context differs because there's no postInterrupt method to be called.
Nevertheless I'd consider the risk low because of the small size of the fix.

Tested with the included test.

The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests.
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8323782 needs maintainer approval

Issue

• JDK-8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/130/head:pull/130
$ git checkout pull/130

Update a local copy of the PR:
$ git checkout pull/130
$ git pull https://git.openjdk.org/jdk22u.git pull/130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 130

View PR using the GUI difftool:
$ git pr show -t 130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/130.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 829d047: Merge
• 8ba20c7: 8327391: Add SipHash attribution file
• e351052: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
• 1d7689d: Merge
• ae46fb7: Merge
• bf87bb7: Merge
• 733b837: 8322122: Enhance generation of addresses
• a7ac67c: Merge
• 0082d4c: Merge
• 8ac813a: 8315708: Enhance HTTP/2 client usage
• ... and 20 more: https://git.openjdk.org/jdk22u/compare/20d95c5046099624fba5ae0aadb2a0f67d1635c5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (8d8c96a7)

[openjdk]

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[reinrich]

Thanks for reviewing.
/integrate

[openjdk]

Going to push as commit 1188d40.
Since your change was applied there have been 32 commits pushed to the master branch:

• 0c57256: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
• 2ae0188: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp
• 829d047: Merge
• 8ba20c7: 8327391: Add SipHash attribution file
• e351052: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
• 1d7689d: Merge
• ae46fb7: Merge
• bf87bb7: Merge
• 733b837: 8322122: Enhance generation of addresses
• a7ac67c: Merge
• ... and 22 more: https://git.openjdk.org/jdk22u/compare/20d95c5046099624fba5ae0aadb2a0f67d1635c5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit 1188d40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.