8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment

[minborg]

Hi all,

This pull request contains a backport of commit 93579c29 from the openjdk/jdk repository.

The commit being backported was authored by Per Minborg on 25 Mar 2024 and was reviewed by Maurizio Cimadamore.

Thanks!

---

Progress

• JDK-8323552 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment (Bug - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/131/head:pull/131
$ git checkout pull/131

Update a local copy of the PR:
$ git checkout pull/131
$ git pull https://git.openjdk.org/jdk22u.git pull/131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 131

View PR using the GUI difftool:
$ git pr show -t 131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/131.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

• ca393c8: 8330576: ZYoungCompactionLimit should have range check
• 66cdc14: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition
• 70bd2c7: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
• f867d97: 8331746: Create a test to verify that the cmm id is not ignored
• 3ed85b9: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
• 851922d: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
• 3663b2d: 8327501: Common ForkJoinPool prevents class unloading in some cases
• b96b4f6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
• 5a659b7: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• e32e05b: 8329840: Fix ZPhysicalMemorySegment::_end type
• ... and 94 more: https://git.openjdk.org/jdk22u/compare/92d6fa4abec1fdf8e57723e4490be0ba4f97e59d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @minborg This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (8abfdb73)

[bridgekeeper]

@minborg This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[minborg]

Please review this PR.

[minborg]

/approval request This is a clean backport of a bug discovered in 22

[openjdk]

@minborg
8323552: The approval request has been created successfully.

[shipilev]

This PR is clean, so it does not nominally requires review. You have maintainer approval for it, so it can go in.

[minborg]

/integrate

[openjdk]

@minborg
Your change (at version 8abfdb7) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 91a2e75.
Since your change was applied there have been 104 commits pushed to the master branch:

• ca393c8: 8330576: ZYoungCompactionLimit should have range check
• 66cdc14: 8329958: Windows x86 build fails: downcallLinker.cpp(36) redefinition
• 70bd2c7: 8328075: Shenandoah: Avoid forwarding when objects don't move in full-GC
• f867d97: 8331746: Create a test to verify that the cmm id is not ignored
• 3ed85b9: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
• 851922d: 8331164: createJMHBundle.sh download jars fail when url needed to be redirected
• 3663b2d: 8327501: Common ForkJoinPool prevents class unloading in some cases
• b96b4f6: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM
• 5a659b7: 8326446: The User and System of jdk.CPULoad on Apple M1 are inaccurate
• e32e05b: 8329840: Fix ZPhysicalMemorySegment::_end type
• ... and 94 more: https://git.openjdk.org/jdk22u/compare/92d6fa4abec1fdf8e57723e4490be0ba4f97e59d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @minborg Pushed as commit 91a2e75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.