-
Notifications
You must be signed in to change notification settings - Fork 57
8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync #133
8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync #133
Conversation
…adSync Reviewed-by: dholmes, stuefe, mdoerr, tholenstein, aph
👋 Welcome back rrich! A progress list of the required criteria for merging this PR into |
@reinrich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 30 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
Thanks for reviewing. |
Going to push as commit 0c57256.
Your commit was automatically rebased without conflicts. |
Hi,
this PR contains a backport of commit openjdk/jdk@e41bc42.
It did not apply cleanly because
JfrRecorderService::emit_leakprofiler_events()
does not exist in jdk 22 so I left out the hunk injfrRecorderService.cpp
.Testing:
I've verified every added
WXState
change if it is actually required.The fix passed our CI testing with
AssertWXAtThreadSync
enabled: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/133/head:pull/133
$ git checkout pull/133
Update a local copy of the PR:
$ git checkout pull/133
$ git pull https://git.openjdk.org/jdk22u.git pull/133/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 133
View PR using the GUI difftool:
$ git pr show -t 133
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/133.diff
Webrev
Link to Webrev Comment