Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329823: RISC-V: Need to sync CPU features with related JVM flags #135

Closed

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Apr 10, 2024

Hi, The same issue also exists in the jdk22u. I would like to backport 8329823 to jdk22u. With this backport, We synchronize these features with related JVM flags so that "features" string can reflect actual usable CPU features.

Testing

  • Run tier1 tests on SOPHON SG2042 (release)

Results without specifying any jvm flags(After applying this patch)

----------System.out:(4/135)----------
WB.getCPUFeatures(): "rv64 i m a f d c"
CPUInfo.getAdditionalCPUInfo(): ""
CPUInfo.getFeatures(): [rv64, i, m, a, f, d, c]
TEST PASSE

Results with specifying -XX:-UseRVC (After applying this patch)

----------System.out:(4/130)----------
WB.getCPUFeatures(): "rv64 i m a f d"
CPUInfo.getAdditionalCPUInfo(): ""
CPUInfo.getFeatures(): [rv64, i, m, a, f, d]
TEST PASSED

Results with specifying -XX:+UseRVC (After applying this patch)

----------System.out:(4/135)----------
WB.getCPUFeatures(): "rv64 i m a f d c"
CPUInfo.getAdditionalCPUInfo(): ""
CPUInfo.getFeatures(): [rv64, i, m, a, f, d, c]
TEST PASSED

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329823 needs maintainer approval

Issue

  • JDK-8329823: RISC-V: Need to sync CPU features with related JVM flags (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/135/head:pull/135
$ git checkout pull/135

Update a local copy of the PR:
$ git checkout pull/135
$ git pull https://git.openjdk.org/jdk22u.git pull/135/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 135

View PR using the GUI difftool:
$ git pr show -t 135

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/135.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329823: RISC-V: Need to sync CPU features with related JVM flags

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • dbaca7a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
  • 98a63a8: 8328589: unify os::breakpoint among posix platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport b9331cd25ca88b07ce079405f5e3031cf8c13ea6 8329823: RISC-V: Need to sync CPU features with related JVM flags Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

This backport pull request has now been updated with issue from the original commit.

@zifeihan zifeihan marked this pull request as ready for review April 10, 2024 08:08
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Apr 10, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 10, 2024
@zifeihan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@zifeihan
Your change (at version 2bc5342) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

Going to push as commit bcf0d25.
Since your change was applied there have been 4 commits pushed to the master branch:

  • dbaca7a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
  • 98a63a8: 8328589: unify os::breakpoint among posix platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2024
@openjdk openjdk bot closed this Apr 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@RealFYang @zifeihan Pushed as commit bcf0d25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants