8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers

[TobiHartmann]

Hi all,

This pull request contains a backport of commit 4cd31875 from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Astigeevich on 6 Feb 2024 and was reviewed by Andrew Haley and Nick Gasson.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324874 needs maintainer approval

Issue

• JDK-8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/138/head:pull/138
$ git checkout pull/138

Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.org/jdk22u.git pull/138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 138

View PR using the GUI difftool:
$ git pr show -t 138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/138.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 3d99b8f: 8309218: java/util/concurrent/locks/Lock/OOMEInAQS.java still times out with ZGC, Generational ZGC, and SerialGC
• 64b4949: 8328316: Finisher cannot emit if stream is sequential and integrator returned false
• bcf0d25: 8329823: RISC-V: Need to sync CPU features with related JVM flags
• dbaca7a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
• 3b35164: 8329545: [s390x] Fix garbage value being passed in Argument Register
• 817cf13: 8328702: C2: Crash during parsing because sub type check is not folded
• 98a63a8: 8328589: unify os::breakpoint among posix platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9d5132ec)

[theRealAph]

Hi all,

This pull request contains a backport of commit 4cd31875 from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Astigeevich on 6 Feb 2024 and was reviewed by Andrew Haley and Nick Gasson.

Thanks!

Progress

* [x]  Change must not contain extraneous whitespace

* [x]  Commit message must refer to an issue

* [ ]  [JDK-8324874](https://bugs.openjdk.org/browse/JDK-8324874) needs maintainer approval

Issue

* [JDK-8324874](https://bugs.openjdk.org/browse/JDK-8324874): AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers (**Bug** - P4 - Requested)

Reviewing

Using git
Using Skara CLI tools
Using diff file

Webrev

Link to Webrev Comment

This is a clean backport, right?

[TobiHartmann]

Yes, see the clean label.

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 52b43e9.
Since your change was applied there have been 33 commits pushed to the master branch:

• 5f333b5: 8326106: Write and clear stack trace table outside of safepoint
• ccb1a3e: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
• ac9ca97: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause
• 1188d40: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
• 0c57256: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
• 2ae0188: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp
• 829d047: Merge
• 8ba20c7: 8327391: Add SipHash attribution file
• e351052: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
• 1d7689d: Merge
• ... and 23 more: https://git.openjdk.org/jdk22u/compare/22230b34d79010c6e639f55248cd6ce6be8c22e5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 52b43e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.