Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination #14

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 9, 2024

Clean backport for trivial little inefficiency.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8323065 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/14/head:pull/14
$ git checkout pull/14

Update a local copy of the PR:
$ git checkout pull/14
$ git pull https://git.openjdk.org/jdk22u.git pull/14/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14

View PR using the GUI difftool:
$ git pr show -t 14

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/14.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eb9e754b3a439cc3ce36c2c9393bc8b250343844 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport for trivial little inefficiency.

@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@shipilev
8323065: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 3257d9d: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
  • 4c8b839: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • 484138e: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • 9e1e6e1: 8321480: ISO 4217 Amendment 176 Update
  • 648ebea: Merge
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • ... and 12 more: https://git.openjdk.org/jdk22u/compare/085dccd28b9ac4fe9278f61e3e99c80ede01d947...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 15, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

Going to push as commit dfce95a.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 3257d9d: 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
  • 4c8b839: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • 484138e: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • 9e1e6e1: 8321480: ISO 4217 Amendment 176 Update
  • 648ebea: Merge
  • e5f3366: 8322418: Problem list gc/TestAllocHumongousFragment.java subtests for 8298781
  • 29ed387: 8322532: JShell : Unnamed variable issue
  • 2110300: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • f27efd6: 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
  • 0442d77: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • ... and 12 more: https://git.openjdk.org/jdk22u/compare/085dccd28b9ac4fe9278f61e3e99c80ede01d947...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 15, 2024
@openjdk openjdk bot closed this Jan 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@shipilev Pushed as commit dfce95a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant