Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8329961: Buffer overflow in os::Linux::kernel_version #141

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Apr 12, 2024

Follow-up fix to JDK-8321075 which is in 22.0.2. Should be low risk and avoids the potential buffer-overrun.


Progress

  • JDK-8329961 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329961: Buffer overflow in os::Linux::kernel_version (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.org/jdk22u.git pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/141.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2024

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329961: Buffer overflow in os::Linux::kernel_version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 279ed0ddd505fb3052b818f755b4b220ed5557e6 8329961: Buffer overflow in os::Linux::kernel_version Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

This backport pull request has now been updated with issue from the original commit.

@jerboaa jerboaa marked this pull request as ready for review April 12, 2024 16:35
@openjdk openjdk bot added approval rfr Pull request is ready for review labels Apr 12, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 17, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2024

@jerboaa This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jerboaa
Copy link
Contributor Author

jerboaa commented May 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2024

Going to push as commit f5ce46f.
Since your change was applied there have been 70 commits pushed to the master branch:

  • 0f3b3fa: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • c3e9084: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • bb3651f: 8331167: UBSan enabled build fails in adlc on macOS
  • 5550682: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • dd5581c: 8331331: :tier1 target explanation in doc/testing.md is incorrect
  • 2cb2e6b: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • cbfaf28: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • 61792bc: 8331344: No compiler replay file with CompilerCommand MemLimit
  • 9b3187f: 8330027: Identity hashes of archived objects must be based on a reproducible random seed
  • 9486b7c: 8324243: Compilation failures in java.desktop module with gcc 14
  • ... and 60 more: https://git.openjdk.org/jdk22u/compare/3d99b8fc2145456608fa90e823254c52b6c5302b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2024
@openjdk openjdk bot closed this May 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

@jerboaa Pushed as commit f5ce46f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant