Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8328744: Parallel: Parallel GC throws OOM before heap is fully expanded #143

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 15, 2024

A clean backport.


Progress

  • JDK-8328744 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328744: Parallel: Parallel GC throws OOM before heap is fully expanded (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/143/head:pull/143
$ git checkout pull/143

Update a local copy of the PR:
$ git checkout pull/143
$ git pull https://git.openjdk.org/jdk22u.git pull/143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 143

View PR using the GUI difftool:
$ git pr show -t 143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/143.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2024

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328744: Parallel: Parallel GC throws OOM before heap is fully expanded

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 142c311e3b9bd3f00edaa6ba7bcbc9fc285ee9b9 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded Apr 15, 2024
@openjdk
Copy link

openjdk bot commented Apr 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

⚠️ @zhengyu123 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 15, 2024
@zhengyu123
Copy link
Contributor Author

/integrate

Approved.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

Going to push as commit bf8146e.
Since your change was applied there have been 28 commits pushed to the master branch:

  • bde0fad: 8330011: [s390x] update block-comments to make code consistent
  • 52b43e9: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • 5f333b5: 8326106: Write and clear stack trace table outside of safepoint
  • ccb1a3e: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • ac9ca97: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause
  • 1188d40: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
  • 0c57256: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
  • 2ae0188: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp
  • 829d047: Merge
  • 8ba20c7: 8327391: Add SipHash attribution file
  • ... and 18 more: https://git.openjdk.org/jdk22u/compare/3d99b8fc2145456608fa90e823254c52b6c5302b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2024
@openjdk openjdk bot closed this Apr 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@zhengyu123 Pushed as commit bf8146e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123
Copy link
Contributor Author

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@zhengyu123 the backport was successfully created on the branch backport-zhengyu123-bf8146ea in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit bf8146ea from the openjdk/jdk22u repository.

The commit being backported was authored by Zhengyu Gu on 22 Apr 2024 and had no reviewers.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-zhengyu123-bf8146ea:backport-zhengyu123-bf8146ea
$ git checkout backport-zhengyu123-bf8146ea
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-zhengyu123-bf8146ea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant