-
Notifications
You must be signed in to change notification settings - Fork 59
8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp #146
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
/sponsor |
Going to push as commit 2ae0188.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit 2ae0188. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a followup fix for JDK-8326936 which has been backported to jdk22u. I would like to also have this for jdk22u so that gcc
__atomic_compare_exchange
atomic operation could still be used for the upcoming gcc-13.3 release. This is a risc-v specific change. Backport is clean, risk is low.Testing
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/146/head:pull/146
$ git checkout pull/146
Update a local copy of the PR:
$ git checkout pull/146
$ git pull https://git.openjdk.org/jdk22u.git pull/146/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 146
View PR using the GUI difftool:
$ git pr show -t 146
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/146.diff
Webrev
Link to Webrev Comment