Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8328953: JEditorPane.read throws ChangedCharSetException #148

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Apr 17, 2024

Backporting JDK-8328953: JEditorPane.read throws ChangedCharSetException.

The patch applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328953 needs maintainer approval

Issue

  • JDK-8328953: JEditorPane.read throws ChangedCharSetException (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.org/jdk22u.git pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/148.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328953: JEditorPane.read throws ChangedCharSetException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 245514da51ef77757f530317e079a3f58370a0be 8328953: JEditorPane.read throws ChangedCharSetException Apr 17, 2024
@openjdk
Copy link

openjdk bot commented Apr 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 17, 2024

⚠️ @aivanov-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Apr 17, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 21, 2024
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

Going to push as commit 849b720.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 890e046: 8320707: Virtual thread test updates
  • 53f758e: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • a93848c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • bf8146e: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • bde0fad: 8330011: [s390x] update block-comments to make code consistent
  • 52b43e9: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • 5f333b5: 8326106: Write and clear stack trace table outside of safepoint
  • ccb1a3e: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • ac9ca97: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause
  • 1188d40: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
  • ... and 19 more: https://git.openjdk.org/jdk22u/compare/ae466e271fbc3b7a3a794dc08585e14f99dd0f81...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2024
@openjdk openjdk bot closed this Apr 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@aivanov-jdk Pushed as commit 849b720.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant