Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8330011: [s390x] update block-comments to make code consistent #153

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Apr 18, 2024

Hi all,

This pull request contains a backport of commit 01bda278 from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 17 Apr 2024 and was reviewed by Lutz Schmidt.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330011 needs maintainer approval

Issue

  • JDK-8330011: [s390x] update block-comments to make code consistent (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/153/head:pull/153
$ git checkout pull/153

Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jdk22u.git pull/153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 153

View PR using the GUI difftool:
$ git pr show -t 153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/153.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330011: [s390x] update block-comments to make code consistent

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 01bda278d6a498ca89c0bc5218680cd51a04e9d3 8330011: [s390x] update block-comments to make code consistent Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2024

Webrevs

@offamitkumar
Copy link
Member Author

/approval request This change doesn't effect the working, instead adds consistency for how we have used block-comments in past on s390x.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@offamitkumar
8330011: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 18, 2024
@offamitkumar
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 21, 2024
@openjdk
Copy link

openjdk bot commented Apr 21, 2024

@offamitkumar
Your change (at version 110ea53) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

Going to push as commit bde0fad.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 52b43e9: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • 5f333b5: 8326106: Write and clear stack trace table outside of safepoint
  • ccb1a3e: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • ac9ca97: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause
  • 1188d40: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
  • 0c57256: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync
  • 2ae0188: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp
  • 829d047: Merge
  • 8ba20c7: 8327391: Add SipHash attribution file
  • e351052: 8325313: Header format error in TestIntrinsicBailOut after JDK-8317299
  • ... and 15 more: https://git.openjdk.org/jdk22u/compare/c45dbbcf20f5febf330bdbfc21260697aa01c0a2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2024
@openjdk openjdk bot closed this Apr 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@shipilev @offamitkumar Pushed as commit bde0fad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants