-
Notifications
You must be signed in to change notification settings - Fork 57
8330011: [s390x] update block-comments to make code consistent #153
8330011: [s390x] update block-comments to make code consistent #153
Conversation
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This change doesn't effect the working, instead adds consistency for how we have used block-comments in past on s390x. |
@offamitkumar |
/integrate |
@offamitkumar |
/sponsor |
Going to push as commit bde0fad.
Your commit was automatically rebased without conflicts. |
@shipilev @offamitkumar Pushed as commit bde0fad. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 01bda278 from the openjdk/jdk repository.
The commit being backported was authored by Amit Kumar on 17 Apr 2024 and was reviewed by Lutz Schmidt.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/153/head:pull/153
$ git checkout pull/153
Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jdk22u.git pull/153/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 153
View PR using the GUI difftool:
$ git pr show -t 153
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/153.diff
Webrev
Link to Webrev Comment