Skip to content
This repository was archived by the owner on Jul 17, 2024. It is now read-only.

8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive #154

Closed

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented Apr 19, 2024

Clean backport to jdk22u. Already ported to jdk21u-oracle

hs-tier1, hs-tier2, hs-tier3 tests are green


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324933 needs maintainer approval

Issue

  • JDK-8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.org/jdk22u.git pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/154.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2024

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0e2fdc95ae47c11e6a1e47cdc6190268e29a9d9c 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

⚠️ @coffeys This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 19, 2024
@coffeys
Copy link
Contributor Author

coffeys commented Apr 22, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

Going to push as commit ccb1a3e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • ac9ca97: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2024
@openjdk openjdk bot closed this Apr 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@coffeys Pushed as commit ccb1a3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant