-
Notifications
You must be signed in to change notification settings - Fork 61
8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes #157
Conversation
|
/approval request Fixes a corner case bug/inefficiency in Epsilon. Applies cleanly. Testing passes. Risk is low, the patch is simple and limited to Epsilon. |
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/integrate |
|
Going to push as commit 53f758e.
Your commit was automatically rebased without conflicts. |
Fixes a corner case bug in Epsilon.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/157/head:pull/157$ git checkout pull/157Update a local copy of the PR:
$ git checkout pull/157$ git pull https://git.openjdk.org/jdk22u.git pull/157/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 157View PR using the GUI difftool:
$ git pr show -t 157Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/157.diff
Webrev
Link to Webrev Comment