Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes #157

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 19, 2024

Fixes a corner case bug in Epsilon.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328166 needs maintainer approval

Issue

  • JDK-8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/157/head:pull/157
$ git checkout pull/157

Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.org/jdk22u.git pull/157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 157

View PR using the GUI difftool:
$ git pr show -t 157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/157.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

/approval request Fixes a corner case bug/inefficiency in Epsilon. Applies cleanly. Testing passes. Risk is low, the patch is simple and limited to Epsilon.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • a93848c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • bf8146e: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • bde0fad: 8330011: [s390x] update block-comments to make code consistent
  • 52b43e9: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • 5f333b5: 8326106: Write and clear stack trace table outside of safepoint
  • ccb1a3e: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • ac9ca97: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 90ab52e598f74ed872fe404130d57f6596430727 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@shipilev
8328166: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 19, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 23, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

Going to push as commit 53f758e.
Since your change was applied there have been 7 commits pushed to the master branch:

  • a93848c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • bf8146e: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • bde0fad: 8330011: [s390x] update block-comments to make code consistent
  • 52b43e9: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • 5f333b5: 8326106: Write and clear stack trace table outside of safepoint
  • ccb1a3e: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • ac9ca97: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2024
@openjdk openjdk bot closed this Apr 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@shipilev Pushed as commit 53f758e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant