8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks

[shipilev]

Clean backport to improve C2 reliability.

Additional testing:

• New test DOES NOT fail without the patch, passes with it
• GHA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8329163 needs maintainer approval
• JDK-8324121 needs maintainer approval

Issues

• JDK-8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks (Bug - P3 - Approved)
• JDK-8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks() (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/159/head:pull/159
$ git checkout pull/159

Update a local copy of the PR:
$ git checkout pull/159
$ git pull https://git.openjdk.org/jdk22u.git pull/159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 159

View PR using the GUI difftool:
$ git pr show -t 159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/159.diff

Webrev

Link to Webrev Comment

[shipilev]

/issue add 8329163

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 0f4bc65: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• 71d0fcf: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• 4395278: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• 5de1d5c: 8323670: A few client tests intermittently throw ConcurrentModificationException
• e66cf81: 8305072: Win32ShellFolder2.compareTo is inconsistent
• 849b720: 8328953: JEditorPane.read throws ChangedCharSetException
• 890e046: 8320707: Virtual thread test updates
• 53f758e: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
• a93848c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
• bf8146e: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
• ... and 1 more: https://git.openjdk.org/jdk22u/compare/52b43e99280ea81409db3cb664f391d3163ffb8d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev
Adding additional issue to issue list: 8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks().

[mlbridge]

Webrevs

• 00: Full (8911fdda)

[shipilev]

Both backports are clean.

/clean

[openjdk]

@shipilev This backport pull request is now marked as clean

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval 8324121 request Clean backport to improve C2 reliability against overflows. Applies cleanly. GHA tests pass. The new regression test unfortunately passes even without the fix. Usual risk for C2 changes, but the change looks simple enough, and there is only a tiny bugtail: JDK-8329163.

/approval 8329163 request Clean backport, follow-up for JDK-8324121. GHA tests pass.

[openjdk]

@shipilev
8324121: The approval request has been created successfully.

[openjdk]

@shipilev
8329163: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit 437d655.
Since your change was applied there have been 16 commits pushed to the master branch:

• b2fbc82: 8322962: Upcall stub might go undetected when freezing frames
• f08201c: 8325095: C2: bailout message broken: ResourceArea allocated string used after free
• e6ba0ee: 8325179: Race in BasicDirectoryModel.validateFileCache
• 7381b84: 8320692: Null icon returned for .exe without custom icon
• 5eb11e5: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
• 0f4bc65: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• 71d0fcf: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• 4395278: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• 5de1d5c: 8323670: A few client tests intermittently throw ConcurrentModificationException
• e66cf81: 8305072: Win32ShellFolder2.compareTo is inconsistent
• ... and 6 more: https://git.openjdk.org/jdk22u/compare/52b43e99280ea81409db3cb664f391d3163ffb8d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 437d655.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.