Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8320707: Virtual thread test updates #160

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 22, 2024

Test-only backport that simplifies Loom maintenance. This would make subsequent backports clean.

Additional testing:

  • MacOS AArch64 server fastdebug, jdk_loom hotspot_loom

Progress

  • Change must not contain extraneous whitespace
  • JDK-8320707 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8320707: Virtual thread test updates (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jdk22u.git pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/160.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320707: Virtual thread test updates

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 53f758e: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • a93848c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • bf8146e: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • bde0fad: 8330011: [s390x] update block-comments to make code consistent

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b67b71cd87c62f15d5b73f923c300d0f77c988f5 8320707: Virtual thread test updates Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Test-only backport that simplifies Loom maintenance. The original commit applies cleanly, Loom tests pass. Low risk, test-only change.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@shipilev
8320707: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 22, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

Going to push as commit 890e046.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 53f758e: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • a93848c: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • bf8146e: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • bde0fad: 8330011: [s390x] update block-comments to make code consistent

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2024
@openjdk openjdk bot closed this Apr 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@shipilev Pushed as commit 890e046.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant