Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
/ jdk22u Public archive

8323685: PrintSystemDictionaryAtExit has mutex rank assert #162

Closed

Conversation

tschatzl
Copy link

@tschatzl tschatzl commented Apr 23, 2024

Hi all,

This pull request contains a backport of commit 2865afe7 from the openjdk/jdk repository.

The commit being backported was authored by Coleen Phillimore on 19 Jan 2024 and was reviewed by Thomas Schatzl and Albert Mingkun Yang.

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323685 needs maintainer approval

Issue

  • JDK-8323685: PrintSystemDictionaryAtExit has mutex rank assert (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/162/head:pull/162
$ git checkout pull/162

Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.org/jdk22u.git pull/162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 162

View PR using the GUI difftool:
$ git pr show -t 162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/162.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2024

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323685: PrintSystemDictionaryAtExit has mutex rank assert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 0f4bc65: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
  • 71d0fcf: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
  • 4395278: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • 5de1d5c: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • e66cf81: 8305072: Win32ShellFolder2.compareTo is inconsistent
  • 849b720: 8328953: JEditorPane.read throws ChangedCharSetException
  • 890e046: 8320707: Virtual thread test updates
  • 53f758e: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2865afe759fd5362abd0947fd4c1f5c8d3519ca3 8323685: PrintSystemDictionaryAtExit has mutex rank assert Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

⚠️ @tschatzl This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 23, 2024
@tschatzl
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

Going to push as commit bb313b5.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 437d655: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
  • b2fbc82: 8322962: Upcall stub might go undetected when freezing frames
  • f08201c: 8325095: C2: bailout message broken: ResourceArea allocated string used after free
  • e6ba0ee: 8325179: Race in BasicDirectoryModel.validateFileCache
  • 7381b84: 8320692: Null icon returned for .exe without custom icon
  • 5eb11e5: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
  • 0f4bc65: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
  • 71d0fcf: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
  • 4395278: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • 5de1d5c: 8323670: A few client tests intermittently throw ConcurrentModificationException
  • ... and 4 more: https://git.openjdk.org/jdk22u/compare/a93848c1438fd96ac79d62b2e8bb4f495e65bc42...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 30, 2024
@openjdk openjdk bot closed this Apr 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 30, 2024
@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@tschatzl Pushed as commit bb313b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant