-
Notifications
You must be signed in to change notification settings - Fork 57
8320692: Null icon returned for .exe without custom icon #167
8320692: Null icon returned for .exe without custom icon #167
Conversation
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
Going to push as commit 7381b84.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk Pushed as commit 7381b84. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8320692: Null icon returned for .exe without custom icon.
It is a regression introduced by JDK-8293862.
The patch applies cleanly.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22u.git pull/167/head:pull/167
$ git checkout pull/167
Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.org/jdk22u.git pull/167/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 167
View PR using the GUI difftool:
$ git pr show -t 167
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk22u/pull/167.diff
Webrev
Link to Webrev Comment